quartznet/pulsar
2
0
Fork 0
mirror of https://github.com/9ParsonsB/Pulsar.git synced 2025-04-05 17:39:39 -04:00
Code Actions

Handle disposed timer object in ResetTimer() (#104)

Browse Source 
I've had this occur a number of times (twice in a row yesterday) where if you receive new records while doing a long read-all, this exception crashes ObsCore.

So may need some further digging, but in the meantime, it won't crash here.
This commit is contained in:
F K 2023-03-01 14:51:23 -05:00 committed by GitHub
parent 6298316c94
commit 7e401adb6f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
ObservatoryCore/PluginManagement/PluginEventHandler.cs
View File

@ -22,6 +22,11 @@ namespace Observatory.PluginManagement
this.observatoryNotifiers = observatoryNotifiers; this.observatoryNotifiers = observatoryNotifiers;
errorList = new(); errorList = new();
InitializeTimer();
}
private void InitializeTimer()
{
// Use a timer to delay error reporting until incoming errors are "quiet" for one full second. // Use a timer to delay error reporting until incoming errors are "quiet" for one full second.
// Should resolve issue where repeated plugin errors open hundreds of error windows. // Should resolve issue where repeated plugin errors open hundreds of error windows.
timer = new(); timer = new();
@ -107,7 +112,17 @@ namespace Observatory.PluginManagement
private void ResetTimer() private void ResetTimer()
{ {
timer.Stop(); timer.Stop();
timer.Start(); try
{
timer.Start();
}
catch (ObjectDisposedException ode)
{
// Not sure why this happens, but I've reproduced it twice in a row after hitting
// read-all while also playing (ie. generating journals).
InitializeTimer();
timer.Start();
}
} }
private void RecordError(PluginException ex) private void RecordError(PluginException ex)