From 7e401adb6f7ea9251dad57eb347273820cf22a13 Mon Sep 17 00:00:00 2001
From: F K <54195004+fredjk-gh@users.noreply.github.com>
Date: Wed, 1 Mar 2023 14:51:23 -0500
Subject: [PATCH] Handle disposed timer object in ResetTimer() (#104)

I've had this occur a number of times (twice in a row yesterday) where if you receive new records while doing a long read-all, this exception crashes ObsCore.

So may need some further digging, but in the meantime, it won't crash here.
---
 .../PluginManagement/PluginEventHandler.cs      | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/ObservatoryCore/PluginManagement/PluginEventHandler.cs b/ObservatoryCore/PluginManagement/PluginEventHandler.cs
index c9d44ec..d9cbf2d 100644
--- a/ObservatoryCore/PluginManagement/PluginEventHandler.cs
+++ b/ObservatoryCore/PluginManagement/PluginEventHandler.cs
@@ -22,6 +22,11 @@ namespace Observatory.PluginManagement
             this.observatoryNotifiers = observatoryNotifiers;
             errorList = new();
 
+            InitializeTimer();
+        }
+
+        private void InitializeTimer()
+        {
             // Use a timer to delay error reporting until incoming errors are "quiet" for one full second.
             // Should resolve issue where repeated plugin errors open hundreds of error windows.
             timer = new();
@@ -107,7 +112,17 @@ namespace Observatory.PluginManagement
         private void ResetTimer()
         {
             timer.Stop();
-            timer.Start();
+            try
+            {
+                timer.Start();
+            }
+            catch (ObjectDisposedException ode)
+            {
+                // Not sure why this happens, but I've reproduced it twice in a row after hitting
+                // read-all while also playing (ie. generating journals).
+                InitializeTimer();
+                timer.Start();
+            }
         }
 
         private void RecordError(PluginException ex)