From 737062763d7c992924f8b1dafdb59daf4cc02135 Mon Sep 17 00:00:00 2001
From: Fall <73458244+Fallbork@users.noreply.github.com>
Date: Wed, 1 Jun 2022 07:53:13 -0300
Subject: [PATCH] Updated CBool to have a greater utility, closer to how C++'s
 booleans operate (#110)

---
 Raylib-cs/types/native/CBool.cs | 66 ++++++++++++++++++++++++++++-----
 1 file changed, 56 insertions(+), 10 deletions(-)

diff --git a/Raylib-cs/types/native/CBool.cs b/Raylib-cs/types/native/CBool.cs
index 11dd92f..d3a8e5f 100644
--- a/Raylib-cs/types/native/CBool.cs
+++ b/Raylib-cs/types/native/CBool.cs
@@ -6,26 +6,72 @@ namespace Raylib_cs
     [StructLayout(LayoutKind.Sequential)]
     public readonly struct CBool
     {
-        private readonly byte value;
+        /* The values of booleans in C++ are stored in a single byte, which means it
+         * only supports values from -128 to 127. It is possible to argument that
+         * they only support a single bit, yes, but the minimum storage unit of a
+         * computer is a sbyte, so that's what we'll be using when doing operations,
+         * which can be later implicitely cast onto any type during usage.
+         * 
+         * It is wise to note that C booleans are any numeric value, but allocating an
+         * Int64 for every CBool instance is.. well, wildly memory-inefficient. Yes, the
+         * process is basically treated as a 0-cost instantiation, but it's better to rely
+         * on explicit motivation than to blindly trust the runtime judgement on its memory
+         * management. 
+         * 
+         * 'value' is visible and constructable, but impossible to modify or access.
+         */
+        public sbyte value { init; private get; }
 
-        private CBool(bool value)
+        // CBool -> Native
+        // Allows for arithmetic between CBools and for assignment to greater integer variables.
+        public static implicit operator sbyte(CBool x)
         {
-            this.value = Convert.ToByte(value);
-        }
-
-        public static implicit operator CBool(bool value)
-        {
-            return new CBool(value);
+            return x.value;
         }
 
+        // Allows for CBools to be implicitely assigned to a native boolean variable
         public static implicit operator bool(CBool x)
         {
-            return Convert.ToBoolean(x.value);
+            return x.value != 0 ? true : false;
         }
 
+        // Native -> CBool
+        // Allows native booleans to be implicitely constructed into CBools while passing parameters.
+        public static implicit operator CBool(bool x)
+        {
+            return new CBool { value = (sbyte)(x ? 1 : 0) };
+        }
+
+        // Same goes for integer numeric values (any value, so an Int64 is used).
+        public static implicit operator CBool(Int64 x)
+        {
+            return new CBool { value = (sbyte)x };
+        }
+
+        /* Arithmetic overloads
+         * Operations between CBools and integers are already covered by the implicit
+         * sbyte cast. So no need to worry about those.
+         * 
+         * All casts return CBool, since there is no way to know if the assignment is
+         * to a native boolean or integer, or a CBool.
+         */
+
+        // Addition
+        public static CBool operator +(CBool left, CBool right)
+        {
+            return new CBool { value = (sbyte)(left.value + right.value) };
+        }
+
+        // Subtraction
+        public static CBool operator -(CBool left, CBool right)
+        {
+            return new CBool { value = (sbyte)(left.value - right.value) };
+        }
+        
+        // ToString override
         public override string ToString()
         {
-            return Convert.ToBoolean(value).ToString();
+            return ((bool)this).ToString();
         }
     }
 }