From fc4d038645bc56436d4eb79a5d4e7fefc103c6d0 Mon Sep 17 00:00:00 2001
From: F K <54195004+fredjk-gh@users.noreply.github.com>
Date: Sat, 28 May 2022 17:26:47 -0400
Subject: [PATCH] Workaround journal bug: Already mapped bodies are not
 undiscovered (#85)

Just checking something is not already discovered is not enough. Many valuable bodies in the bubble mis-fire this criteria because the journal reports them as not discovered (because they have no first discoverer because they're well known systems). Checking that they're also not mapped ensures this doesn't happen.

Also simplified rendering of the string info.
---
 ObservatoryExplorer/DefaultCriteria.cs | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/ObservatoryExplorer/DefaultCriteria.cs b/ObservatoryExplorer/DefaultCriteria.cs
index 679541f..5a51699 100644
--- a/ObservatoryExplorer/DefaultCriteria.cs
+++ b/ObservatoryExplorer/DefaultCriteria.cs
@@ -59,15 +59,18 @@ namespace Observatory.Explorer
                 {
                     var info = new System.Text.StringBuilder();
                                         
-                    if (!scan.WasDiscovered)
-                        info.Append("Undiscovered ");
-                    else if (!scan.WasMapped)
-                        info.Append("Unmapped ");
+                    if (!scan.WasMapped)
+                    {
+                        if (!scan.WasDiscovered)
+                            info.Append("Undiscovered ");
+                        else
+                            info.Append("Unmapped ");
+                    }
 
                     if (scan.TerraformState?.Length > 0)
                         info.Append("Terraformable ");
 
-                    results.Add("High-Value Body", $"{(info.Length > 1 ? info.ToString() : string.Empty)}{textInfo.ToTitleCase(scan.PlanetClass)}, {scan.DistanceFromArrivalLS:N0}Ls");
+                    results.Add("High-Value Body", $"{info.ToString()}{textInfo.ToTitleCase(scan.PlanetClass)}, {scan.DistanceFromArrivalLS:N0}Ls");
                 }
             }
             #endregion