quartznet/pulsar
2
0
Fork 0
mirror of https://github.com/9ParsonsB/Pulsar.git synced 2025-04-05 17:39:39 -04:00
Code Actions

[Herald+Core] Send notifications to plugins during read-all in Debug (#136)

Browse Source 
This will allow notifications to be sent to Notification listeners during read-all to enhance testability.

This is controlled by the `DEBUG` compiler directive, so Release versions will not have this behaviour.

However, Herald, being a plugin itself, should ignore these otherwise the results are.... unfortunate. #askmehowiknow
This commit is contained in:
F K 2024-01-29 15:36:03 -05:00 committed by GitHub
parent ad1df66379
commit a555c86083
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
ObservatoryCore/PluginManagement/PluginCore.cs
View File

@ -46,13 +46,22 @@ namespace Observatory.PluginManagement
{ {
var guid = Guid.Empty; var guid = Guid.Empty;
if (!IsLogMonitorBatchReading) #if DEBUG // For exercising testing notifier plugins in read-all
{
if (notificationArgs.Rendering.HasFlag(NotificationRendering.PluginNotifier)) if (notificationArgs.Rendering.HasFlag(NotificationRendering.PluginNotifier))
{ {
var handler = Notification; var handler = Notification;
handler?.Invoke(this, notificationArgs); handler?.Invoke(this, notificationArgs);
} }
#endif
if (!IsLogMonitorBatchReading)
{
#if !DEBUG
if (notificationArgs.Rendering.HasFlag(NotificationRendering.PluginNotifier))
{
var handler = Notification;
handler?.Invoke(this, notificationArgs);
}
#endif
if (!OverridePopup && Properties.Core.Default.NativeNotify && notificationArgs.Rendering.HasFlag(NotificationRendering.NativeVisual)) if (!OverridePopup && Properties.Core.Default.NativeNotify && notificationArgs.Rendering.HasFlag(NotificationRendering.NativeVisual))
{ {

6
ObservatoryHerald/HeraldNotifier.cs
View File

@ -6,6 +6,8 @@ namespace Observatory.Herald
{ {
public class HeraldNotifier : IObservatoryNotifier public class HeraldNotifier : IObservatoryNotifier
{ {
private IObservatoryCore Core;
public HeraldNotifier() public HeraldNotifier()
{ {
heraldSettings = DefaultSettings; heraldSettings = DefaultSettings;
@ -53,8 +55,10 @@ namespace Observatory.Herald
} }
} }
} }
public void Load(IObservatoryCore observatoryCore) public void Load(IObservatoryCore observatoryCore)
{ {
Core = observatoryCore;
var speechManager = new SpeechRequestManager( var speechManager = new SpeechRequestManager(
heraldSettings, observatoryCore.HttpClient, observatoryCore.PluginStorageFolder, observatoryCore.GetPluginErrorLogger(this)); heraldSettings, observatoryCore.HttpClient, observatoryCore.PluginStorageFolder, observatoryCore.GetPluginErrorLogger(this));
heraldSpeech = new HeraldQueue(speechManager, observatoryCore.GetPluginErrorLogger(this), observatoryCore); heraldSpeech = new HeraldQueue(speechManager, observatoryCore.GetPluginErrorLogger(this), observatoryCore);
@ -77,6 +81,8 @@ namespace Observatory.Herald
public void OnNotificationEvent(NotificationArgs notificationEventArgs) public void OnNotificationEvent(NotificationArgs notificationEventArgs)
{ {
if (Core.IsLogMonitorBatchReading) return;
if (heraldSettings.Enabled && notificationEventArgs.Rendering.HasFlag(NotificationRendering.NativeVocal)) if (heraldSettings.Enabled && notificationEventArgs.Rendering.HasFlag(NotificationRendering.NativeVocal))
heraldSpeech.Enqueue( heraldSpeech.Enqueue(
notificationEventArgs, notificationEventArgs,