From 3f2f11bdf398de0436b28d1f61f52b23fb3f72b7 Mon Sep 17 00:00:00 2001
From: F K <54195004+fredjk-gh@users.noreply.github.com>
Date: Wed, 1 Mar 2023 14:52:20 -0500
Subject: [PATCH] [Framework + Core] Feature: Add support for adding multiple
 grid items (#105)

For plugin developers: Adds a new method to the IObservatoryCore interface to add multiple grid items in 1 call -- which only invokes the UI thread once (and potentially only scrolls to bottom once) providing a small performance improvement and providing some modest convenience.
---
 .../PluginManagement/PluginCore.cs            | 47 ++++++++++++++-----
 ObservatoryFramework/Interfaces.cs            |  7 +++
 2 files changed, 42 insertions(+), 12 deletions(-)

diff --git a/ObservatoryCore/PluginManagement/PluginCore.cs b/ObservatoryCore/PluginManagement/PluginCore.cs
index 10443cc..3fa0637 100644
--- a/ObservatoryCore/PluginManagement/PluginCore.cs
+++ b/ObservatoryCore/PluginManagement/PluginCore.cs
@@ -105,21 +105,28 @@ namespace Observatory.PluginManagement
                 //Hacky removal of original empty object if one was used to populate columns
                 if (worker.PluginUI.DataGrid.Count == 2)
                 {
-                    bool allNull = true;
-                    Type itemType = worker.PluginUI.DataGrid[0].GetType();
-                    foreach (var property in itemType.GetProperties())
-                    {
-                        if (property.GetValue(worker.PluginUI.DataGrid[0], null) != null)
-                        {
-                            allNull = false;
-                            break;
-                        }
-                    }
-
-                    if (allNull)
+                    if (FirstRowIsAllNull(worker))
                         worker.PluginUI.DataGrid.RemoveAt(0);
                 }
+            });
+        }
 
+        /// <summary>
+        /// Adds multiple items to the datagrid on UI thread to ensure visual update.
+        /// </summary>
+        /// <param name="worker"></param>
+        /// <param name="items"></param>
+        public void AddGridItems(IObservatoryWorker worker, IEnumerable<object> items)
+        {
+            Avalonia.Threading.Dispatcher.UIThread.InvokeAsync(() =>
+            {
+                var cleanEmptyRow = worker.PluginUI.DataGrid.Count == 1 && FirstRowIsAllNull(worker) && items.Count() > 0;
+                foreach (var item in items)
+                {
+                    worker.PluginUI.DataGrid.Add(item);
+                }
+                if (cleanEmptyRow)
+                    worker.PluginUI.DataGrid.RemoveAt(0);
             });
         }
 
@@ -175,5 +182,21 @@ namespace Observatory.PluginManagement
         {
             NativePopup.CloseAll();
         }
+
+        private static bool FirstRowIsAllNull(IObservatoryWorker worker)
+        {
+            bool allNull = true;
+            Type itemType = worker.PluginUI.DataGrid[0].GetType();
+            foreach (var property in itemType.GetProperties())
+            {
+                if (property.GetValue(worker.PluginUI.DataGrid[0], null) != null)
+                {
+                    allNull = false;
+                    break;
+                }
+            }
+
+            return allNull;
+        }
     }
 }
diff --git a/ObservatoryFramework/Interfaces.cs b/ObservatoryFramework/Interfaces.cs
index c50d05d..3a1a73b 100644
--- a/ObservatoryFramework/Interfaces.cs
+++ b/ObservatoryFramework/Interfaces.cs
@@ -156,6 +156,13 @@ namespace Observatory.Framework.Interfaces
         /// <param name="item">Grid item to be added. Object type should match original template item used to create the grid.</param>
         public void AddGridItem(IObservatoryWorker worker, object item);
 
+        /// <summary>
+        /// Add multiple items to the bottom of the basic UI grid.
+        /// </summary>
+        /// <param name="worker">Reference to the calling plugin's worker interface.</param>
+        /// <param name="items">Grid items to be added. Object types should match original template item used to create the grid.</param>
+        public void AddGridItems(IObservatoryWorker worker, IEnumerable<object> items);
+
         /// <summary>
         /// Clears basic UI grid, removing all items.
         /// </summary>