quartznet/pulsar
Watch
2
0
Fork
You've already forked pulsar
 0
Code Issues Pull requests Activity Actions

Error handling improvements (#92)

Browse source 
* Consolidate plugin errors into single window.

* Handle error aggregation and loggin inside error reporter.

* Minor logging corrections.

* Error popup tweaking
This commit is contained in:
Jonathan Miller 2022-07-24 15:48:55 -02:30 • committed by GitHub
commit 342d5af11c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 80 additions and 61 deletions
Download patch file Download diff file Expand all files Collapse all files

4
ObservatoryCore/UI/ViewModels/CoreViewModel.cs
View file

@ -207,8 +207,8 @@ namespace Observatory.UI.ViewModels
{
ObservatoryCore.LogError(e, "while exporting data");
ErrorReporter.ShowErrorPopup("Error encountered!",
"An error occurred while exporting; output may be missing or incomplete." + Environment.NewLine +
"Please check the error log (found in your Documents folder) for more details and visit our discord to report it.");
new List<(string, string)> { ("An error occurred while exporting; output may be missing or incomplete." + Environment.NewLine +
"Please check the error log (found in your Documents folder) for more details and visit our discord to report it.", e.Message) });
}
}

2
ObservatoryCore/UI/ViewModels/MainWindowViewModel.cs
View file

@ -11,7 +11,7 @@ namespace Observatory.UI.ViewModels
core = new CoreViewModel(pluginManager.workerPlugins, pluginManager.notifyPlugins);
if (pluginManager.errorList.Any())
ErrorReporter.ShowErrorPopup("Plugin Load Error", string.Join(Environment.NewLine, pluginManager.errorList));
ErrorReporter.ShowErrorPopup("Plugin Load Error", pluginManager.errorList);
}
public CoreViewModel core { get; }