quartznet/pulsar
2
0
Fork 0
mirror of https://github.com/9ParsonsB/Pulsar.git synced 2025-04-05 17:39:39 -04:00
Code Actions

Fix a couple of invalid thread exceptions in NativePopup notifications (#43)

Browse Source 
Manipulating active notifications must be done on the Avalonia UI thread. UpdateNotification and CloseNotification were not properly doing this.

Any plugin attempting to use persistent notifications would have encountered these errors.

NOTE: There is not yet hooks for cleaning up persistent/infinite timeout notifications when the APP is closed.
This commit is contained in:
F K 2021-12-18 13:46:57 -05:00 committed by GitHub
parent b2d0637146
commit 177707f6ae
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
ObservatoryCore/NativeNotification/NativePopup.cs
View File

@ -8,6 +8,7 @@ namespace Observatory.NativeNotification
{
public class NativePopup
{
// TODO: This needs to be cleaned up when the app is closed.
private Dictionary<Guid, NotificationView> notifications;
public NativePopup()
@ -48,13 +49,23 @@ namespace Observatory.NativeNotification
public void CloseNotification(Guid guid)
{
if (notifications.ContainsKey(guid))
notifications[guid].Close();
{
Avalonia.Threading.Dispatcher.UIThread.InvokeAsync(() =>
{
notifications[guid].Close();
});
}
}
public void UpdateNotification(Guid guid, NotificationArgs notificationArgs)
{
if (notifications.ContainsKey(guid))
notifications[guid].DataContext = new NotificationViewModel(notificationArgs);
{
Avalonia.Threading.Dispatcher.UIThread.InvokeAsync(() =>
{
notifications[guid].DataContext = new NotificationViewModel(notificationArgs);
});
}
}
}
}