From 08a8aa31565f427f6315e0ae778400b6dc4bd434 Mon Sep 17 00:00:00 2001
From: Xjph <archseraphim@gmail.com>
Date: Sat, 23 Oct 2021 13:03:22 -0230
Subject: [PATCH] don't save empty fileinfo settings

---
 ObservatoryCore/UI/Views/BasicUIView.axaml.cs | 29 ++++++++++---------
 1 file changed, 16 insertions(+), 13 deletions(-)

diff --git a/ObservatoryCore/UI/Views/BasicUIView.axaml.cs b/ObservatoryCore/UI/Views/BasicUIView.axaml.cs
index e1d2e3d..c486b40 100644
--- a/ObservatoryCore/UI/Views/BasicUIView.axaml.cs
+++ b/ObservatoryCore/UI/Views/BasicUIView.axaml.cs
@@ -854,7 +854,7 @@ namespace Observatory.UI.Views
                             settingsGrid.AddControl(label, settingsGrid.RowDefinitions.Count - 1, 0);
                             settingsGrid.AddControl(intControl, settingsGrid.RowDefinitions.Count - 1, 1);
                             break;
-                        case System.IO.FileInfo fileSetting:
+                        case FileInfo fileSetting:
                             label.Text += ": ";
 
                             TextBox settingPath = new()
@@ -887,7 +887,7 @@ namespace Observatory.UI.Views
                                     {
                                         string path = browseTask.Result[0];
                                         Avalonia.Threading.Dispatcher.UIThread.InvokeAsync(() => { settingPath.Text = path; });
-                                        setting.Key.SetValue(plugin.Settings, new System.IO.FileInfo(path));
+                                        setting.Key.SetValue(plugin.Settings, new FileInfo(path));
                                         PluginManagement.PluginManager.GetInstance.SaveSettings(plugin, plugin.Settings);
 
                                     }
@@ -897,19 +897,22 @@ namespace Observatory.UI.Views
 
                             settingPath.LostFocus += (object sender, RoutedEventArgs e) =>
                             {
-                                string fullPath;
-                                
-                                try
+                                if (settingPath.Text.Trim() != string.Empty)
                                 {
-                                    fullPath = System.IO.Path.GetFullPath(settingPath.Text);
-                                }
-                                catch
-                                {
-                                    fullPath = string.Empty;
-                                }
+                                    string fullPath;
 
-                                setting.Key.SetValue(plugin.Settings, new System.IO.FileInfo(fullPath));
-                                PluginManagement.PluginManager.GetInstance.SaveSettings(plugin, plugin.Settings);
+                                    try
+                                    {
+                                        fullPath = Path.GetFullPath(settingPath.Text);
+                                    }
+                                    catch
+                                    {
+                                        fullPath = string.Empty;
+                                    }
+
+                                    setting.Key.SetValue(plugin.Settings, new FileInfo(fullPath));
+                                    PluginManagement.PluginManager.GetInstance.SaveSettings(plugin, plugin.Settings);
+                                }
                             };
 
                             StackPanel stackPanel = new() { Orientation = Avalonia.Layout.Orientation.Horizontal };